Better handle stability attributes when merging WIT packages#1669
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 15, 2024
Merged
Better handle stability attributes when merging WIT packages#1669alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit updates the logic when merging WIT packages together to better handle stability. This isn't perfect but it should suffice to fix the issue in bytecodealliance#1666. The general idea is that stability is something that needs to be specifically handled during the merging process and it erroneously wasn't processed at all before. This commit fixes that and fixes a panic along the way. Stability is now inherited if possible but generates an error if two packages disagree. Closes bytecodealliance#1666
This was referenced Jul 13, 2024
pchickey
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic when merging WIT packages together to better handle stability. This isn't perfect but it should suffice to fix the issue in #1666. The general idea is that stability is something that needs to be specifically handled during the merging process and it erroneously wasn't processed at all before. This commit fixes that and fixes a panic along the way. Stability is now inherited if possible but generates an error if two packages disagree.
Closes #1666