Support delegate instruction and update other exception instructions#223
Merged
alexcrichton merged 4 commits intobytecodealliance:mainfrom Feb 17, 2021
Merged
Conversation
The spec now specifies that `catch_all` has a separate opcode from `else`.
The end of an unwind should check that the block was empty, but it needs to push the try block type as the result.
Member
|
Thanks! And yeah a submodule update would be great! That can be tricky sometimes though so let me know if there's any trouble |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
delegateinstruction that's part of the exception handling proposal. It was previously left out because it didn't have an opcode assignment, but the latest spec explainer (WebAssembly/exception-handling#137 (comment)) includes it.It also updates/fixes support for other instructions to match recent spec updates. For example,
catch_allis no longer sharing an opcode withelse.With these patches, exception support should also match the behavior in wabt's tests (when including these pending PRs: WebAssembly/wabt#1608 and WebAssembly/wabt#1605). I can submit a PR later to enable exception handling tests that are currently disabled once wabt PRs are merged and the submodule can be updated.