fail validation if callback missing for async export #2273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the module exports a function with the `[async-lift]` prefix (rather than the `[async-lift-stackful]` one), then we must be able to match that up with a corresponding callback function; otherwise, we fail validation. Prior to this fix, we'd silently generate an invalid component and leave it to `wasmparser` to notice, which is bad form, plus the diagnostic message wasn't very helpful. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the module exports a function with the
[async-lift]prefix (rather than the[async-lift-stackful]one), then we must be able to match that up with a corresponding callback function; otherwise, we fail validation.Prior to this fix, we'd silently generate an invalid component and leave it to
wasmparserto notice, which is bad form, plus the diagnostic message wasn't very helpful.