Add support for the WASM_DYLINK_RUNTIME_PATH subsection of the dylink.0 custom section #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 custom section
alexcrichton
approved these changes
Aug 15, 2025
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! And no worries about the breaking change, it's expected that this crate has breaking changes over time as wasm evolves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds support for the
WASM_DYLINK_RUNTIME_PATHsubsection.wasm-ld21 already supports generating this subsection via the-rpatharg, so I feel it's important forwasm-toolsto support the subsection as well.I don't know of any tools that generate the subsection in WAT format yet, but judging by the information in https://github.com/WebAssembly/tool-conventions/blob/main/DynamicLinking.md#text-format-of-dylink0, the correct format should be
(runtime-path "a" "b"); please correct me if I'm wrong.I believe this is a breaking change to
wasmparser, in the sense that adding a new case toDylink0Subsectionbreaks existing code that does exhaustive matching on it; however, I don't know if there's a better way to handle this.