Remove --generate-dwarf from options in --help messages where it doesn't make sense #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
force-pushed
the
no-generate-dwarf
branch
from
e6a6454 to
b32e7ce
Compare
…n't make sense Previously, a lot of subcommands listed the --generate-dwarf option in cases where no output file is produced, or where it doesn't make sense to add debug info. This change refactors the options to separate the option to generate DWARF from the generic input/output options. The commands affected are: shrink, mutate, dump, objdump, strip, demangle, `component wit`, `component targets`, and `metadata show`. The --help messages for these commands no longer include --generate-dwarf.
catamorphism
force-pushed
the
no-generate-dwarf
branch
from
b32e7ce to
e04bf2d
Compare
Contributor
Author
|
I initially thought |
Member
|
I see that this is a draft PR -- should I hold off on taking a look for a little while? |
Contributor
Author
|
@fitzgen Yes, I'll mark it as ready for review once CI is done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a lot of subcommands listed the --generate-dwarf option in cases where no output file is produced, or where it doesn't make sense to add debug info. This change refactors the options to separate the option to generate DWARF from the generic input/output options.
The commands affected are: shrink, mutate, dump, objdump, strip, demangle,
component wit,component targets, andmetadata show. The --help messages for these commands no longer include --generate-dwarf.