Print offset of final end in wasm-tools print -p
#2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking at a validation error recently where the offset printed for an error wasn't present in `wasm-tools print -p`, and that was because the error was on the final `end` instruction of a function which isn't printed in the text format. This commit updates the output of `-p` to include a comment with an offset for the `end` instruction.
abrown
approved these changes
Sep 19, 2025
Contributor
|
Would it be possible to print this offset with the closing parenthesis (which currently lacks an offset) rather than with a new |
Member
Author
|
@keithw I tried to do that at first yeah as I agree it'd be nice to not print the extra line, but I ended up giving up because it felt a bit weird threading things around and figured this was "good enough". All that to say, please feel free to send a follow-up! You'll probably have more success than I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at a validation error recently where the offset printed for an error wasn't present in
wasm-tools print -p, and that was because the error was on the finalendinstruction of a function which isn't printed in the text format. This commit updates the output of-pto include a comment with an offset for theendinstruction.