Skip to content

feat(compose): enable all features during component validation #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Oct 15, 2025
Merged

feat(compose): enable all features during component validation #2354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/bin/wasm-tools/compose.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use anyhow::{Context, Result};
use clap::Parser;
use std::path::{Path, PathBuf};
use wasm_compose::{composer::ComponentComposer, config::Config};
use wasmparser::Validator;
use wasmparser::{Validator, WasmFeatures};

/// WebAssembly component composer.
///
Expand Down Expand Up @@ -68,13 +68,15 @@ impl Opts {
if config.skip_validation {
log::debug!("output validation was skipped");
} else {
Validator::new().validate_all(&bytes).with_context(|| {
let output = match self.output.output_path() {
Some(s) => format!(" `{}`", s.display()),
None => String::new(),
};
format!("failed to validate output component{output}")
})?;
Validator::new_with_features(WasmFeatures::all())
.validate_all(&bytes)
.with_context(|| {
let output = match self.output.output_path() {
Some(s) => format!(" `{}`", s.display()),
None => String::new(),
};
format!("failed to validate output component{output}")
})?;

log::debug!("output component validated successfully");
}
Expand Down