Structured resolver errors#2482
Draft
PhoebeSzmucer wants to merge 13 commits intobytecodealliance:mainfrom
Draft
Structured resolver errors#2482PhoebeSzmucer wants to merge 13 commits intobytecodealliance:mainfrom
PhoebeSzmucer wants to merge 13 commits intobytecodealliance:mainfrom
Conversation
This reverts commit 0692157.
Member
|
Happy to take a look when you feel this is ready, but I'm interpreting the draft state as "come back later" for now -- just wanted to note this |
Contributor
Author
|
Thanks @alexcrichton. No review needed just yet - I'm still cleaning up some final things and do one more self review, and I'll mark it as ready soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2460 (part 1 was here).
This PR replaces most of
anyhowusages in the resolver with structuredParserErrortype, which carries structured error information (with spans).