Handle the rename of "events" to "tags" in exception handling proposal#291
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Jun 23, 2021
Merged
Conversation
A recent PR to wabt changed the printing slightly for these test cases: WebAssembly/wabt#1669
The exception handling proposal spec was recently changed to rename the event section to the tag section, in order to use a clearer name that conflicts with fewer things in the web context: WebAssembly/exception-handling#161
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception handling proposal spec recently renamed "events" to "tags" in order to use a clearer name (WebAssembly/exception-handling#161). This means the event section is now the tag section and so on. This PR handles the renaming for wasm-tools (in the last commit).
This change has already landed in wabt (WebAssembly/wabt#1678) so this PR also updates the wabt test submodule in the first commit.
Updating the submodule also requires some changes to a linking test because of some wabt printing changes (https://github.com/WebAssembly/wabt/pull/1669/files). This is in the second commit.