Typecheck declare and actual inline module types#37
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Jul 10, 2020
Merged
Typecheck declare and actual inline module types#37alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This should finish the initial implementation of the module linking proposal in this repository. The last piece that I can think of was to validate the declared module types (the module section) against the actual module types (the module code section).
yurydelendik
approved these changes
Jul 9, 2020
Contributor
yurydelendik
left a comment
yurydelendik
left a comment
There was a problem hiding this comment.
Looks good. It is nice to see documentation (or TODO comments) on how instance and module types are compared. Currently, we assume that we have named imports/exports and their order shall match when two types are compared.
Member
Author
|
Ok I'm gonna go ahead and merge this. I'll need to rebase #40 anyway for this and I'll make sure to add docs there as part of the rebase. |
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Feb 6, 2023
…erences Update function-references branch, fix tests, update style
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Dec 4, 2023
Merge up to wasm-tools-1.0.54 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should finish the initial implementation of the module linking
proposal in this repository. The last piece that I can think of was to
validate the declared module types (the module section) against the
actual module types (the module code section).