wasm-smith: generate shared memory when --threads is present#624
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom Jun 8, 2022
Merged
wasm-smith: generate shared memory when --threads is present#624alexcrichton merged 5 commits intobytecodealliance:mainfrom
--threads is present#624alexcrichton merged 5 commits intobytecodealliance:mainfrom
Conversation
One of the parts to the threads proposal is the addition of shared memory. This change allows `wasm-smith` to generate Wasm code using memory that is shared; it does not include the other parts of the threads proposal (atomics, `wait/notify`).
11 tasks
fitzgen
reviewed
Jun 8, 2022
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Thanks! Looks good, modulo what Alex already pointed out, and another little thing below.
alexcrichton
reviewed
Jun 8, 2022
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
…odealliance#624) * wasm-smith: generate shared memory when `--threads` is present One of the parts to the threads proposal is the addition of shared memory. This change allows `wasm-smith` to generate Wasm code using memory that is shared; it does not include the other parts of the threads proposal (atomics, `wait/notify`). * fix: doc tests * review: use 'Unstructured::ratio' * review: add 'threads_enabled' to 'SwarmConfig' * review: disable threads in 'SwarmConfig'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the parts to the threads proposal is the addition of shared
memory. This change allows
wasm-smithto generate Wasm code usingmemory that is shared; it does not include the other parts of the
threads proposal (atomics,
wait/notify).