Implement module/component alias sugar when instantiating#627
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jun 8, 2022
Merged
Implement module/component alias sugar when instantiating#627alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
The syntax for instantiation changed slightly in bytecodealliance#621 where a bare index is now required, but this syntax prevents the inline injection and usage of an alias of an export of another component/instance. This commit soups up the support here by bringing back the `IndexOrRef` structure which can be used to parse one of the two, allowing both a bare reference plus a parenthesized reference that enables alias injection.
peterhuene
approved these changes
Jun 8, 2022
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Ah, thanks for fixing this! Hopefully there weren't other places where I was a little too literal with the spec interpretation.
Member
Author
|
I grepped around and we're not using the |
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
…liance#627) The syntax for instantiation changed slightly in bytecodealliance#621 where a bare index is now required, but this syntax prevents the inline injection and usage of an alias of an export of another component/instance. This commit soups up the support here by bringing back the `IndexOrRef` structure which can be used to parse one of the two, allowing both a bare reference plus a parenthesized reference that enables alias injection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syntax for instantiation changed slightly in #621 where a bare index
is now required, but this syntax prevents the inline injection and usage
of an alias of an export of another component/instance. This commit
soups up the support here by bringing back the
IndexOrRefstructurewhich can be used to parse one of the two, allowing both a bare
reference plus a parenthesized reference that enables alias injection.