wasmprinter: remove variant case identifiers.#643
Merged
peterhuene merged 1 commit intobytecodealliance:mainfrom Jun 17, 2022
Merged
wasmprinter: remove variant case identifiers.#643peterhuene merged 1 commit intobytecodealliance:mainfrom
peterhuene merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit removes the identifiers from variant cases; instead, a `refines` clause references the case by index.
Member
Author
|
This was code review feedback that fell through the cracks during the review of #621. |
alexcrichton
approved these changes
Jun 17, 2022
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Oops, thanks for catching this!
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
This commit removes the identifiers from variant cases; instead, a `refines` clause references the case by index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the identifiers from variant cases; instead, a
refinesclause references the case by index.