This repository was archived by the owner on Jun 16, 2020. It is now read-only.
Rename memory instructions.#53
Merged
yurydelendik merged 1 commit intobytecodealliance:masterfrom Jun 8, 2018
Merged
Conversation
The wasm instructions `grow_memory` and `current_memory` were renamed to `memory.grow` and `memory.size`, respectively: WebAssembly/spec#720 The patch here renames wasmparser.rs's `GrowMemory` and `CurrentMemory` to `MemoryGrow` and `MemorySize`, to better align with the spec.
Collaborator
|
Thank you for the patch |
Robbepop
pushed a commit
to Robbepop/wasmparser
that referenced
this pull request
Jun 11, 2020
This is WIP specified in the reference types proposal. For example, it's in the text format and execution text, but not the binary encoding or validation text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm instructions
grow_memoryandcurrent_memorywere renamed tomemory.growandmemory.size, respectively:WebAssembly/spec#720
The patch here renames wasmparser.rs's
GrowMemoryandCurrentMemoryto
MemoryGrowandMemorySize, to better align with the spec.