Implement module linking. #49
Merged
peterhuene merged 5 commits intobytecodealliance:mainfrom Jan 19, 2021
peterhuene:module-linking
Merged
Implement module linking. #49peterhuene merged 5 commits intobytecodealliance:mainfrom peterhuene:module-linking
peterhuene merged 5 commits intobytecodealliance:mainfrom
peterhuene:module-linking
Conversation
This commit implements the changes to support the module linking proposal. Modules and instances are now supported import types for module instantiation. Modules can now also be instantiated via `Module.Instantiate` and `ModuleExtern.Instantiate`. There is a breaking change to the API: * `Instance.Externs` has been removed in favor of individual properties that forward to the inner `Externs` instance. Thus `Instance.Externs.Functions` becomes `Instance.Functions`, etc. Additionally, the examples and the test project have been migrated to .NET 5. Closes #45. Fixes #40.
Member
Author
|
CI is expected to fail for this PR as there's a breaking change upstream in Wasmtime which is what the CI is testing against. Tests pass locally so I won't block this PR on CI. The CI will be fixed once the |
Member
Author
|
Merging as tests pass locally (see comment above). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes to support the module linking proposal.
Modules and instances are now supported import types for module instantiation.
Modules can now also be instantiated via
Module.InstantiateandModuleExtern.Instantiate.There is a breaking change to the API:
Instance.Externshas been removed in favor of individual properties thatforward to the inner
Externsinstance. ThusInstance.Externs.Functionsbecomes
Instance.Functions, etc.Additionally, the examples and the test project have been migrated to .NET 5.
Closes #45.
Fixes #40.