Add basic macOS arm64 support#102
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Oct 1, 2021
danielledeleo:jagger/m1-support
Merged
Add basic macOS arm64 support#102alexcrichton merged 1 commit intobytecodealliance:mainfrom danielledeleo:jagger/m1-support
alexcrichton merged 1 commit intobytecodealliance:mainfrom
danielledeleo:jagger/m1-support
Conversation
This commit adds basic support for building on M1 Macs. For now, `libwasmtime.a` for macos_aarch64 must be built manually, but that part seems to be working fine. This workflow works on my M1 MacBook running Monterey: ``` cd wasmtime cargo build -p wasmtime-c-api --release cd ../wasmtime-go ./ci/local.sh ../wasmtime ```
Contributor
Author
|
It seems that cargo |
Member
|
Seems like a good start at least, thanks! I think there's more to do for correctness, yeah, but seems fine to go ahead and land this. |
This was referenced Oct 12, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds basic support for building on M1 Macs. For now,
libwasmtime.afor macos_aarch64 must be built manually, but that part seems to be working fine.This workflow works on my M1 MacBook running Monterey:
All the tests pass except for
TestTrapFramesandTestTrapModuleName: