Add config setter for wasm_component_model#269
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Feb 25, 2026
Merged
Add config setter for wasm_component_model#269alexcrichton merged 3 commits intobytecodealliance:mainfrom
alexcrichton merged 3 commits intobytecodealliance:mainfrom
Conversation
Co-authored-by: effulgentsia <effulgentsia@users.noreply.github.com>
Contributor
Author
|
What's the preferred way to address these test failures? Some options I can think of, but there's probably others I'm not thinking of:
|
Member
|
Wasmtime 42.0.0, which doesn't include the |
Contributor
Author
|
Ok, that makes sense. I updated this PR to only do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Go binding for recently merged bytecodealliance/wasmtime#12630.
While in there, I noticed that
wasm_component_modelwas also missing a Go setter, so added it.There's other C API config options without Go bindings, but they involve memory internals, exceptions, threads, or similar constructs that I'm unsure whether they require deeper Go code changes to support so I left those out of this PR.
Note that tests might fail if they run against v41 of wasmtime instead of HEAD since the
gc_supportsetter was added to the C API after the v41 release.