trap: wire up Code()#92
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 15, 2021
Merged
Conversation
Member
|
Looks good to me! I think there's some CI errors now that the CI builds from wasmtime should be available. |
This complements bytecodealliance/wasmtime#3086 Fixes bytecodealliance#63. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/traps/inspect-trap-code
branch
from
efea5e2 to
5fab5b2
Compare
Contributor
Author
|
@alexcrichton thanks for reviewing. Should be OK now. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements bytecodealliance/wasmtime#3086
My first steps with cgo⚠️
Won't work until the other PR is merged, but I was hoping to get some eyes on it still 😃