Merged
Conversation
This includes a breaking change, following bytecodealliance/wasmtime#5683. `Wasmtime::Linker#define` now takes a store as a first argument.
jbourassa
force-pushed
the
wasmtime-6
branch
from
bf33458 to
862552d
Compare
saulecabrera
approved these changes
Feb 24, 2023
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Changes LGTM -- I re-ran the ci (macos-latest, 3.1) job since it failed, but it didn't gave any additional context on why. I assume nothing related to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a breaking change, following bytecodealliance/wasmtime#5683.
Wasmtime::Linker#definenow takes a store as a first argument.