Consolidate "util" crates for testing#10423
Merged
fitzgen merged 2 commits intobytecodealliance:mainfrom Mar 20, 2025
Merged
Conversation
This commit consolidates all of the existing crates we have for testing into a smaller set of crates. Specifically: * `crates/misc/component-fuzz-util` => `wasmtime-test-util` + `component-fuzz` feature * `crates/misc/component-test-util` => `wasmtime-test-util` + `component` feature * `crates/wast-util` => `wasmtime-test-util` + `wast` feature * `crates/misc/component-macro-test` => `wasmtime-test-macros` The goal is to have one location we put various test helpers/macros rather than our current organically-grown many locations. This is inspired by the test failure on bytecodealliance#10405 where I'd like to refactor more infrastructure to a "test util" location but it wasn't clear where to put it so I wanted to do this refactoring first.
Member
Author
|
this is a commit on the objdump PR to fix the test failure over there, leveraging this PR |
github-actions
bot
added
the
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit consolidates all of the existing crates we have for testing into a smaller set of crates. Specifically:
crates/misc/component-fuzz-util=>wasmtime-test-util+component-fuzzfeaturecrates/misc/component-test-util=>wasmtime-test-util+componentfeaturecrates/wast-util=>wasmtime-test-util+wastfeaturecrates/misc/component-macro-test=>wasmtime-test-macrosThe goal is to have one location we put various test helpers/macros rather than our current organically-grown many locations. This is inspired by the test failure on #10405 where I'd like to refactor more infrastructure to a "test util" location but it wasn't clear where to put it so I wanted to do this refactoring first.