Add --stack-maps to wasmtime objdump#10439
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Mar 20, 2025
Merged
Add --stack-maps to wasmtime objdump#10439alexcrichton merged 2 commits intobytecodealliance:mainfrom
--stack-maps to wasmtime objdump#10439alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
fitzgen
approved these changes
Mar 20, 2025
src/commands/objdump.rs
Outdated
Comment on lines
+66
to
+68
| /// Whether or not to show information about stack maps. | ||
| #[arg(long)] | ||
| stack_maps: bool, |
Member
There was a problem hiding this comment.
This one also seems like it should probably be on by default and won't be too noisy or anything like that.
Member
Author
There was a problem hiding this comment.
Ok I've done some rejiggering of the types and such for clap and I think I got something working, namely --traps turns things on, --traps=false turns things off, and it's on-by-default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10404 and #10405