Skip to content

Run AArch64 Winch tests on CI#10738

Closed
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
alexcrichton:run-aarch64-wich-tests
Closed

Run AArch64 Winch tests on CI#10738
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
alexcrichton:run-aarch64-wich-tests

Conversation

@alexcrichton
Copy link
Member

Most tests pass (yay!), some tests fail, and some tests crash and/or have nondeterministic results. A new WastTest::should_skip_entirely helper is added to avoid running crashing or nondeterministic tests in CI and that should enable all other tests to run in CI to ensure we have a ratchet to prevent future regressions. This should also in theory make testing easier locally with cargo test --test wast.

Closes #9566

Most tests pass (yay!), some tests fail, and some tests crash and/or
have nondeterministic results. A new `WastTest::should_skip_entirely`
helper is added to avoid running crashing or nondeterministic tests in
CI and that should enable all other tests to run in CI to ensure we have
a ratchet to prevent future regressions. This should also in theory make
testing easier locally with `cargo test --test wast`.

Closes bytecodealliance#9566
@alexcrichton alexcrichton requested review from a team as code owners May 7, 2025 00:48
@alexcrichton alexcrichton requested review from abrown and fitzgen and removed request for a team May 7, 2025 00:48
@alexcrichton alexcrichton marked this pull request as draft May 7, 2025 01:18
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:docs Issues related to Wasmtime's documentation winch Winch issues or pull requests labels May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

Subscribe to Label Action

cc @saulecabrera

Details This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:docs", "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

github-actions bot commented May 7, 2025

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton
Copy link
Member Author

After some follow-up discussion I think it's a bit premature for this so I'm going to close this.

@alexcrichton alexcrichton deleted the run-aarch64-wich-tests branch May 7, 2025 20:44
@saulecabrera
Copy link
Member

I opened #10750, with some inspiration from this pull request and after our discussion in our meeting today. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:docs Issues related to Wasmtime's documentation winch Winch issues or pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winch support for AArch64 tough to integrate with tests/wast.rs

2 participants