CacheConfigs are always enabled; clarify directory validation#11376
CacheConfigs are always enabled; clarify directory validation#11376alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
This makes two small changes to the CacheConfig/Cache system:
First, the comments referred to enabled/disabled caches, which is no longer a thing after #10665, so I've removed this. There were also some docs about panics in these cases (which are also now impossible) which I removed.
Second,
CacheConfig::default()/CacheConfig::new()produced configs which would panic if you asked for theirdirectorywithout first callingvalidate, butvalidateis not public API. So instead we return an Option fromCacheConfig::directory()and move the panic toCache::directory()andWorkerThread::directory()which should be impossible to trigger (sincevalidateis called byCache::new). We could alternatively make a ValidatedCacheConfig or something which is returned fromvalidateand store/pass that around, but it seemed a bit overkill to me.cc @benbrandt who was working on this recently in case I'm missing something.