Support exceptions with Pulley#11495
Merged
alexcrichton merged 6 commits intobytecodealliance:mainfrom Aug 21, 2025
Merged
Conversation
This implements Chris's suggestion to avoid special-casing the `raise` libcall and instead let it fully execute for Pulley. The switch of whether to do a native longjmp or a Pulley longjmp is done based on the interpreter state of Wasmtime's configured executor. Closes bytecodealliance#11486 prtest:full
cfallin
requested review from
cfallin
and removed request for
a team and
fitzgen
Member
|
Happy to take this one for review (and thanks for doing this!). Working out a fix to #11489 which I'll want to make sure doesn't conflict (probably won't?) then will review this. |
fitzgen
reviewed
Aug 21, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* Support exceptions with Pulley This implements Chris's suggestion to avoid special-casing the `raise` libcall and instead let it fully execute for Pulley. The switch of whether to do a native longjmp or a Pulley longjmp is done based on the interpreter state of Wasmtime's configured executor. Closes bytecodealliance#11486 prtest:full * Resolve a TODO * Ignore tests on miri that compile wasm * Fix configured builds * Undo typo * Fix another typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Chris's suggestion to avoid special-casing the
raiselibcall and instead let it fully execute for Pulley. The switch of whether to do a native longjmp or a Pulley longjmp is done based on the interpreter state of Wasmtime's configured executor.Closes #11486