Don't allow a preopened file descriptor to be renamed over.#119
Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom Apr 26, 2019
Merged
Conversation
This is consistent with fd_close's behavior, and is likely temporary until other options are designed.
kubkon
added a commit
that referenced
this pull request
Nov 7, 2019
* Fix some Windows warnings. * Implement clock_time_get on Windows. Also update misc_testsuite to include latest clock_time_get test changes. * improve comments * Remove a leftover import. Co-Authored-By: Jakub Konka <kubkon@jakubkonka.com>
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* typo fixes * more typo fixes
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
Refactor test_zkasm to allow adding benchmarks
frank-emrich
added a commit
to frank-emrich/wasmtime
that referenced
this pull request
Mar 6, 2024
…aces (bytecodealliance#119) This PR finalizes the implementation of backtrace creation in the presence of wasmfx stack switching. The only piece missing after this PR is testing, which I'm adding in a separate PR. As of bytecodealliance#117, it is already the case that each `CallThreadState` executing wasm stores a pointer to the underlying `Store`'s `StackChainCell`. This PR changes the existing creation of backtraces in `backtrace.rs` as follows: Previously, `trace_with_trap_state` would call call `trace_through_wasm` for the faulting program position plus all the entries in the current thread's `CallThreadState` chain. Now, instead of calling `trace_through_wasm` directly, `trace_with_trap_state` calls a new function `trace_through_continuations`. The latter takes an optional `StackChain` and iterates all the stacks (= continuation stacks + main stack) therein, calling `trace_through_wasm` for each such stack. If no such `StackChain` is given, it just behaves as before. Note that the invariant established in bytecodealliance#117 ensures that only the most recent execution of wasm may actually be inside a continuation, while all previous `CallThreadState`s must be on the main stack. As a result, we only ever call `trace_through_wasm` such that the old invariants (which we had commented out at some point) hold again: Its parameters `trampoline_sp` and `fp` describe a continuous (!) sequence of stack memory, either on the main stack or inside a `Fiber` stack. Further, we have `trampoline_sp` > `fp` and following the frame pointer chain starting at `fp` eventually leads to a pointer past (= greater or equal than) `trampoline_sp`. --------- Co-authored-by: Daniel Hillerström <daniel.hillerstrom@ed.ac.uk>
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Error if there are two specs on the same term. Closes avanhatt#56
dicej
added a commit
to dicej/wasmtime
that referenced
this pull request
Apr 18, 2025
…-cancel implement subtask cancellation
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 8, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is consistent with fd_close's behavior, and is likely temporary
until other options are designed.