Simplify C++ binding definitions#11936
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Nov 5, 2025
Merged
Conversation
43d1774 to
08bae2a
Compare
Member
Author
|
ping @pchickey, mind taking a look at this? |
This commit adds a shared macro to simplify ownership management in the C++ API and to additionally have a uniform API across types. This is inspired by the component model work where I felt like I was copy/pasting quite a lot and wanted to cut down on that.
08bae2a to
175fd01
Compare
auto-merge was automatically disabled
November 4, 2025 23:56
Pull Request is not mergeable
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 5, 2025
This commit adds a shared macro to simplify ownership management in the C++ API and to additionally have a uniform API across types. This is inspired by the component model work where I felt like I was copy/pasting quite a lot and wanted to cut down on that.
alexcrichton
added a commit
that referenced
this pull request
Nov 6, 2025
* Simplify C++ binding definitions (#11936) This commit adds a shared macro to simplify ownership management in the C++ API and to additionally have a uniform API across types. This is inspired by the component model work where I felt like I was copy/pasting quite a lot and wanted to cut down on that. * Fill out type information for components in C API (#11937) * Fill out type information for components in C API I've concluded that I'll want this for wasmtime-py so this fills out type reflection for various items in the C API. This then additionally extends the C++ API as well. prtest:full * Update crates/c-api/include/wasmtime/component/types/func.h Co-authored-by: Joel Dice <joel.dice@fermyon.com> --------- Co-authored-by: Joel Dice <joel.dice@fermyon.com> --------- Co-authored-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a shared macro to simplify ownership management in the C++ API and to additionally have a uniform API across types. This is inspired by the component model work where I felt like I was copy/pasting quite a lot and wanted to cut down on that.