Skip to content

Update .rustfmt.toml#137

Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom
kubkon:patch-1
May 7, 2019
Merged

Update .rustfmt.toml#137
sunfishcode merged 1 commit intobytecodealliance:masterfrom
kubkon:patch-1

Conversation

@kubkon
Copy link
Member

@kubkon kubkon commented May 7, 2019

Explicitly document the intent for using the default rustfmt settings.

@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 072b2e8 into bytecodealliance:master May 7, 2019
@kubkon kubkon deleted the patch-1 branch May 13, 2019 14:05
kubkon pushed a commit that referenced this pull request Nov 7, 2019
This commit updates `poll_oneoff`'s API in a potentially least
invasive way. That is, it adds unused `WasiCtx` argument to the
syscall which will be required by #137. I am hopeful that this way
 #137 can pass all tests and hence this commit should aid the review
 process.
kubkon added a commit that referenced this pull request Nov 7, 2019
* Fixes #440

This commit introduces a couple of changes/fixes:
* it annotates `log::debug!` messages with "host" to differentiate
  between file descriptors stored on the WASI side (aka the wrappers)
  and those managed by the host (aka the wrapped)
* it fixes #440, i.e., incorrect passing of
  file descriptor to `poll_oneoff` where currently errenously we
  pass in the wrapper instead of the wrapped value
* it adds a couple more `log::debug!` macros calls for easier future
  debugging

* Add partial refactorting to poll_oneoff

This commit lays the groundwork for more clean up to come in
subsequent commits.

* Finalise refactoring of `poll_oneoff`

* Fix compilation error on Windows

* Address majority of suggestions and refactor

Co-authored-by: Marcin Mielniczuk <marmistrz.dev@zoho.eu>

* Add poll_oneoff test case

* Leave timeout in nanoseconds in ClockEventData

Instead of converting the timeout value from nanoseconds to
milliseconds in the host-independent impl, move the conversion
to *nix-specific impl as the conversion is currently only warranted
by the POSIX `poll` syscall.

* Don't fail immediately on bad descriptor

If the user specifies an invalid descriptor inside a subscription,
don't fail immediately but rather generate an event with the thrown
WASI error code, and continue with the remaining, potentially
correct subscriptions.
pchickey added a commit to pchickey/wasmtime that referenced this pull request May 12, 2023
pchickey added a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
dhil pushed a commit to dhil/wasmtime that referenced this pull request Mar 22, 2024
…ance#137)

Just a trivial optimization:
Currently, the `fiber` field of `ContinuationObject` is a `*mut
ContinuationFiber`, but there is no good reason for that pointer
indirection. This PR turns the type of the field into
`ContinuationFiber`.
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Oct 18, 2024
Migrate the logic in the `veri` binary into a `Runner` class.

This is intended to make testing a little easier by providing a library
entry point into the verifier.

Updates avanhatt#79
dicej added a commit to dicej/wasmtime that referenced this pull request May 8, 2025
alexcrichton pushed a commit to alexcrichton/wasmtime that referenced this pull request Oct 8, 2025
bongjunj pushed a commit to prosyslab/wasmtime that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants