Rewrite wasmtime-wasi to use wasi-common, and introduce wastime-wasi-c#170
Merged
sunfishcode merged 6 commits intomasterfrom Jun 3, 2019
Merged
Rewrite wasmtime-wasi to use wasi-common, and introduce wastime-wasi-c#170sunfishcode merged 6 commits intomasterfrom
sunfishcode merged 6 commits intomasterfrom
Conversation
This adds the C WASI implementation as a new crate, wasmtime-wasi-c, and adds a command-line flag to the wasmtime command-line driver to select which WASI implementation to use.
sunfishcode
approved these changes
Jun 3, 2019
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
Looks good.
One additional thing I just thought of here is that we could move preopen_dir into wasi_common, which would keep API issues like FILE_FLAG_BACKUP_SEMANTICS encapsulated inside the wasi_common crate. Do you think that makes sense?
Member
Author
Excellent idea! I'll add it to my todo list :-) |
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
May 14, 2024
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Attach positional information to spec expressions. This is the first stage in the positional information plumbing required to support more helpful error messages. Updates bytecodealliance#169
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Attach positional information to spec expressions. This is the first stage in the positional information plumbing required to support more helpful error messages. Updates bytecodealliance#169
dicej
pushed a commit
to dicej/wasmtime
that referenced
this pull request
May 27, 2025
Merge with main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two major changes:
wasmtimeruntime with wasi-common; this will be the default some time in the future with WASI implementation being purely in Rust, supporting all 3 major platforms (Linux, Mac and Windows)wasmtime)With this PR landing, you can now opt-in to use
wasmtime-wasiby setting--wasi-commonoption at runtime:Also, please note that
wasmtime-wasi-cis only available on *nix platforms. So, if you are experimenting with WASI on Windows, you have to specify the--wasi-commonflag.