Skip to content

Cranelift: Fix FPR saving and shadow space allocation for Windows x64. #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterhuene merged 4 commits into from
May 22, 2020
Merged

Cranelift: Fix FPR saving and shadow space allocation for Windows x64. #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78c3091
Fix FPR saving and shadow space allocation for Windows x64.
May 20, 2020
2cd5ed1
Address code review feedback.
May 21, 2020
54f9cd2
Re-enable tests that were excluded due to the previous limitation.
May 21, 2020
ce5f3e1
Only update XMM save unwind operation offsets when using a FP.
May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,18 +206,6 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool {
("reference_types", "table_copy_on_imported_tables") => return false,
("reference_types", _) => return true,

("misc_testsuite", "export_large_signature")
| ("spec_testsuite", "call")
| ("spec_testsuite", "func")
| ("multi_value", "call")
| ("multi_value", "func") => {
// FIXME These involves functions with very large stack frames that Cranelift currently
// cannot compile using the fastcall (Windows) calling convention.
// See https://github.com/bytecodealliance/wasmtime/pull/1216.
#[cfg(windows)]
return true;
}

_ => {}
},
_ => panic!("unrecognized strategy"),
Expand Down
Loading