Skip to content

Add wasmtime-hostmodule DSL crate #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eira-fransham wants to merge 7 commits into from
Closed

Add wasmtime-hostmodule DSL crate #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a59141
Add `wasmtime-hostmodule` DSL crate
eira-fransham Jun 19, 2019
f7cc35b
Fix workspace when crates aren't reexported by `wasmtime` directly
eira-fransham Jun 19, 2019
c89240a
Allow runtime values in hostmodule macro
eira-fransham Jun 19, 2019
34dad98
Fix use of `extern "C"` in hostmodule
eira-fransham Jun 19, 2019
3552efe
Improve error messages
eira-fransham Jun 19, 2019
e9712db
Convert wasmtime-wast to use hostmodule dsl
eira-fransham Jun 19, 2019
9a6a16a
Fix docs in hostmodule
eira-fransham Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ wasmtime-wasi-c = { path = "wasmtime-wasi-c" }
winapi = "0.3"

[workspace]
members = ["./wasmtime-*"]
Copy link
Member

@sunfishcode sunfishcode Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line for? Is it intentional to exclude lightbeam?

Copy link
Contributor Author

@eira-fransham eira-fransham Jun 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasmtime doesn't import wasmtime-hostmodule, so we have to do this. I would be in favour of making the wasmtime root crate reexport hostmodule but I wanted to get some feedback first. I actually mention this in the first comment, although I wasn't clear enough about it:

I haven't added any code that reexports this from the wasmtime root crate but I could imagine that that would be helpful (plus, it would mean we can remove the workspace glob that I added in 1a59141).


[features]
lightbeam = ["wasmtime-environ/lightbeam", "wasmtime-jit/lightbeam"]
16 changes: 16 additions & 0 deletions wasmtime-hostmodule/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
[package]
name = "wasmtime-hostmodule"
version = "0.1.0"
authors = ["Jef <jackefransham@gmail.com>"]
edition = "2018"

[dependencies]
hlist = "0.1"
cranelift-codegen = "0.30.0"
cranelift-native = "0.30.0"
cranelift-wasm = "0.30.0"
cranelift-entity = "0.30.0"
wasmtime-jit = { path = "../wasmtime-jit" }
wasmtime-runtime = { path = "../wasmtime-runtime" }
wasmtime-environ = { path = "../wasmtime-environ" }
target-lexicon = "0.3.0"
Loading