Fix skipping dead DWARF records#179
Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom Jun 26, 2019
Merged
Conversation
Member
|
Looks good. |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Verify a subset of CLIF `icmp` lowerings. Updates #34
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Verify a subset of CLIF `icmp` lowerings. Updates #34
dicej
pushed a commit
to dicej/wasmtime
that referenced
this pull request
Jun 3, 2025
…cess-and-accessor Refactor access and accessor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like rustc produces a little bit different DWARF now, which found an error in the DWARF record skipping. The patch fixes the logic.
(The #149 might be also needed)