wasi-common virtfs pipe: convert to be Send and Sync; fix Clone#1961
Merged
wasi-common virtfs pipe: convert to be Send and Sync; fix Clone#1961
Conversation
acfoltzer
approved these changes
Jul 1, 2020
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Thank you! Sorry for the oversight here. I mainly was testing with the lucet-wasi test suite, which does not do any thread migration.
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
* The underlying `R`/`W` doesnt need to be Clone, since we just need to clone the Arc it sits behind. * The rights actually shouldn't be behind an Arc - those get mutated separately in each clone.
pchickey
changed the title
acfoltzer
approved these changes
Jul 2, 2020
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Great catch on the Clone behavior as well. I didn't realize the constraint would end up on the type parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1949
When we went to integrate this code, we discovered that we needed these virtual pipes to be
SendandSync. So, I have switched the internal types fromCell/RefCell/RctoArc/RwLock.The
RwLock.{read, write}results are alwaysunwrap()ed because this code does not expose any way for a panic to occur while a lock is held.We also identified that the
Handle::try_clonemethod was incorrect, and did a manual impl ofClonewith the correct semantics.