Update wasmparser to 0.59.0#2013
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 13, 2020
Merged
Conversation
alexcrichton
force-pushed
the
update-wasmparser
branch
from
6b001c7 to
869564a
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @bnjbvr, @fitzgen, @peterhuene DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "lightbeam", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Jul 13, 2020
Comment on lines
+612
to
+620
| pub(crate) fn validator(&self) -> Validator { | ||
| let mut ret = Validator::new(); | ||
| ret.wasm_threads(self.wasm_threads) | ||
| .wasm_bulk_memory(self.wasm_bulk_memory) | ||
| .wasm_multi_value(self.wasm_multi_value) | ||
| .wasm_reference_types(self.wasm_reference_types) | ||
| .wasm_simd(self.wasm_simd); | ||
| return ret; | ||
| } |
Member
There was a problem hiding this comment.
This is a nice clean up over what we had before.
Member
|
Looks like CI is failing because of the fuzz targets failing to build. |
This commit is intended to update wasmparser to 0.59.0. This primarily includes bytecodealliance/wasm-tools#40 which is a large update to how parsing and validation works. The impact on Wasmtime is pretty small at this time, but over time I'd like to refactor the internals here to lean more heavily on that upstream wasmparser refactoring. For now, though, the intention is to get on the train of wasmparser's latest `main` branch to ensure we get bug fixes and such. As part of this update a few other crates and such were updated. This is primarily to handle the new encoding of `ref.is_null` where the type is not part of the instruction encoding any more.
alexcrichton
force-pushed
the
update-wasmparser
branch
from
869564a to
1add5a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is intended to update wasmparser to 0.59.0. This primarily
includes bytecodealliance/wasm-tools#40 which is a large update to how
parsing and validation works. The impact on Wasmtime is pretty small at
this time, but over time I'd like to refactor the internals here to lean
more heavily on that upstream wasmparser refactoring.
For now, though, the intention is to get on the train of wasmparser's
latest
mainbranch to ensure we get bug fixes and such.As part of this update a few other crates and such were updated. This is
primarily to handle the new encoding of
ref.is_nullwhere the type isnot part of the instruction encoding any more.