Enable SIMD instructions from the command line#232
Merged
yurydelendik merged 1 commit intobytecodealliance:masterfrom Jul 31, 2019
Merged
Enable SIMD instructions from the command line#232yurydelendik merged 1 commit intobytecodealliance:masterfrom
yurydelendik merged 1 commit intobytecodealliance:masterfrom
Conversation
yurydelendik
approved these changes
Jul 30, 2019
Contributor
yurydelendik
left a comment
yurydelendik
left a comment
There was a problem hiding this comment.
Looks good. We can remove Cargo.toml's wasmparser changes (they were left from pre-Features change), maybe even keep it are 0.34 so dependabot will do it magically.
This change adds an `--enable-simd` flag to the binaries in this project. This allows the ISA `enable_simd` flag to be set and to configure the validation configuration used by wasmparser to allow SIMD instructions.
Contributor
|
Thank you for the patch! |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Mar 15, 2024
[filetests]: attempt to compile run-command -> wat -> zkasm
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Oct 4, 2024
This patch disables the CI benchmark job. We should reactivate it after our toolchains have been brought up to date with the new binary format.
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Extend state modification clauses to optionally specify a condition variable. The default spec for a state will only apply when none of its condition variables hold. Updates avanhatt#49
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
…liance#233) Attempt verification of the `sdiv` rule, which is relatively complex given: * Two conditions under which it can trap: divide by zero, and the unrepresentable signed case `(-2^{N-1})/(-1)`. * A delicate sequence of instructions to perform the checks, depending on flags behavior. * Multiple instructions in an expansion modifying the same state, therefore the first use of conditional state modification bytecodealliance#232. This PR adds specs required to verify this rule, and has uncovered an apparent bug! The overflow check used to detect the unrepresentable case only works in the 32/64-bit cases, and breaks in 8/16. The bug is filed as bytecodealliance#9537. In order to land the specs and proceed the rule has been marked with the `broken` tag, and `broken` cases excluded from the CI verification run. Updates #34 avanhatt#49
dicej
pushed a commit
to dicej/wasmtime
that referenced
this pull request
Jul 16, 2025
Replace trailers futures with actual trailers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an
--enable-simdflag to the binaries in this project. This allows the ISAenable_simdflag to be set and to configure the validation configuration used by wasmparser to allow SIMD instructions.