x64 new-backend CI: use Cargo.lock in build.#2352
x64 new-backend CI: use Cargo.lock in build.#2352cfallin merged 1 commit intobytecodealliance:mainfrom
Cargo.lock in build.#2352Conversation
We do a `cargo fetch --locked` for most of our CI builds, but `run-experimental-x64-ci.sh` was not doing this. As a result, some CI runs seem to fail depending on which versions of crates they download. A common failure mode is that two different versions of the `syn` crate get into the build somehow, resulting in errors in wiggle/witx. This change simply adds the `--locked` flag to the `cargo test` run for the new x64 backend.
|
I think this should fix the CI failure in #2345. |
|
Hm so in theory |
|
Ah, I see, I had misunderstood what the flag does, then; though I suppose it doesn't hurt to use it here if we use it for other runs? Of note is that this build does turn on the new crate-version resolver (?) with |
|
Yeah if anything I suspect a bug with |
|
Ah after some testing locally this is a bug that was fixed in Cargo, but we're pinned to an older nightly so we don't have it fixed yet. I'll send a PR update. |
3 participants
We do a
cargo fetch --lockedfor most of our CI builds, butrun-experimental-x64-ci.shwas not doing this. As a result, some CIruns seem to fail depending on which versions of crates they download. A
common failure mode is that two different versions of the
syncrateget into the build somehow, resulting in errors in wiggle/witx.
This change simply adds the
--lockedflag to thecargo testrun forthe new x64 backend.