Skip to content

Add stubs for constant relocation in RelocSink#238

Closed
abrown wants to merge 1 commit intobytecodealliance:masterfrom
abrown:reloc-constant
Closed

Add stubs for constant relocation in RelocSink#238
abrown wants to merge 1 commit intobytecodealliance:masterfrom
abrown:reloc-constant

Conversation

@abrown
Copy link
Member

@abrown abrown commented Aug 2, 2019

As discussed in bytecodealliance/cranelift#868 (comment), changes related to relocating constants alter the RelocSink API. This patch adds the new RelocSink::reloc_constant method in wasmtime so that it will continue to build but does not yet implement them.

@abrown
Copy link
Member Author

abrown commented Aug 5, 2019

This will fail until bytecodealliance/cranelift#868 is merged.

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abrown
Copy link
Member Author

abrown commented Aug 26, 2019

This will fail until CraneStation/cranelift#868 is merged.

And until we publish a version of cranelift with it merged.

@sunfishcode sunfishcode mentioned this pull request Sep 4, 2019
@mrowqa mrowqa mentioned this pull request Sep 4, 2019
@sunfishcode
Copy link
Member

This patch was pulled into #292.

@sunfishcode sunfishcode closed this Sep 6, 2019
grishasobol pushed a commit to grishasobol/wasmtime that referenced this pull request Nov 29, 2021
dhil added a commit to dhil/wasmtime that referenced this pull request Oct 16, 2024
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Apr 9, 2025
Support combined expansion filters. On the CLI, comma separated
predicates to the `--filter` option will be interpreted as and.
dicej pushed a commit to dicej/wasmtime that referenced this pull request Jul 17, 2025
…er-mut-self

 Migrate StreamReader::read to &mut self
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants