Add stubs for constant relocation in RelocSink#238
Closed
abrown wants to merge 1 commit intobytecodealliance:masterfrom
Closed
Add stubs for constant relocation in RelocSink#238abrown wants to merge 1 commit intobytecodealliance:masterfrom
abrown wants to merge 1 commit intobytecodealliance:masterfrom
Conversation
Member
Author
|
This will fail until bytecodealliance/cranelift#868 is merged. |
54d0143 to
ed53e6d
Compare
Member
Author
And until we publish a version of cranelift with it merged. |
Closed
Merged
ed53e6d to
632375e
Compare
Member
|
This patch was pulled into #292. |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Oct 16, 2024
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Support combined expansion filters. On the CLI, comma separated predicates to the `--filter` option will be interpreted as and.
dicej
pushed a commit
to dicej/wasmtime
that referenced
this pull request
Jul 17, 2025
…er-mut-self Migrate StreamReader::read to &mut self
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in bytecodealliance/cranelift#868 (comment), changes related to relocating constants alter the
RelocSinkAPI. This patch adds the newRelocSink::reloc_constantmethod in wasmtime so that it will continue to build but does not yet implement them.