Conversation
github-actions
bot
added
cranelift
fitzgen
approved these changes
Nov 25, 2020
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
I guess? I'll take your word for it.
Is it possible to include a regression test?
Member
Author
|
I'll see what I can whip up -- there currently aren't any direct unit tests for the state presented to the |
…r fallthrough returns. This makes the value of `state.reachable()` inaccurate when observing at the tail of functions (in the post-function hook) after an ordinary return instruction.
cfallin
force-pushed
the
cfallin/fix-wasm-reachable
branch
from
2b76b5b to
34d9931
Compare
Member
Author
|
Added a few tests of reachability info, with some plumbing on the dummy environment. |
fitzgen
approved these changes
Nov 25, 2020
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Nice! Thanks for adding these test.
julian-seward1
added a commit
to mozilla-spidermonkey/wasmtime
that referenced
this pull request
Dec 9, 2020
…s merging in the test case): commit 31bac3e Merge: 93c1993 34d9931 Author: Nick Fitzgerald <fitzgen@gmail.com> Date: Wed Nov 25 13:09:05 2020 -0800 Merge pull request bytecodealliance#2450 from bytecodealliance/cfallin/fix-wasm-reachable Fix Wasm translator bug: end of toplevel frame is branched-to only for fallthrough returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the value of
state.reachable()inaccurate when observing atthe tail of functions (in the post-function hook) after an ordinary
return instruction.