Compile Windows releases with a static CRT#247
Merged
tschneidereit merged 1 commit intobytecodealliance:masterfrom Aug 6, 2019
Merged
Compile Windows releases with a static CRT#247tschneidereit merged 1 commit intobytecodealliance:masterfrom
tschneidereit merged 1 commit intobytecodealliance:masterfrom
Conversation
This commit compiles all Rust code for the Windows release with `-Ctarget-feature=+crt-static`. This is targeted at increasing the binary compatibility of the binaries built to not rely on DLLs that aren't always installed on Windows. Notably this statically links the C runtime (notably used by the C++ code) and means that the final binary relies on fewer dlls. This in theory means that the binaries are only limited by the number of APIs they use from Windows. Note that this also matches how we build releases of Rust for MSVC.
Member
Author
|
This is basically the same as #246 but for Windows, and like that I'd like to actually test the releases that get built to make sure this actually is recognized and the right place to configure this |
Member
Author
|
Ok verified working too! Before this PR: After this PR: |
Member
|
LGTM! |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
needless_lifetimes: Clippy suggests that the lifetime is not needed and suggests eliding it. While that is true, making this implicit would hide the fact that the returned value borrows. While some may think this is obvious, I don't think this is obvious for everyone. If I could I would change the default to the opposite. upper_case_acronyms: While clippy is right here, this is how the instructions were named historically. That said, I don't mind renaming it just think that it's not worth it.
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Move the `error_at_pos` method on `ConditionsBuilder` to a shared location as a method of `Program`. This is intended to allow us to generate positional errors from other parts of the verifier codebase. Updates bytecodealliance#169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit compiles all Rust code for the Windows release with
-Ctarget-feature=+crt-static. This is targeted at increasing thebinary compatibility of the binaries built to not rely on DLLs that
aren't always installed on Windows. Notably this statically links the C
runtime (notably used by the C++ code) and means that the final binary
relies on fewer dlls.
This in theory means that the binaries are only limited by the number of
APIs they use from Windows. Note that this also matches how we build
releases of Rust for MSVC.