Don't publish the Windows installer's wixpdb file#263
Merged
tschneidereit merged 1 commit intobytecodealliance:masterfrom Aug 8, 2019
Merged
Don't publish the Windows installer's wixpdb file#263tschneidereit merged 1 commit intobytecodealliance:masterfrom
tschneidereit merged 1 commit intobytecodealliance:masterfrom
Conversation
This file is only useful for debugging the installer itself, which our users really shouldn't need to do.
Member
Author
|
Merging this without waiting for the tests to complete, as the only change is in a step that's skipped for PR CI runs. |
frank-emrich
added a commit
to frank-emrich/wasmtime
that referenced
this pull request
Nov 29, 2024
…ytecodealliance#263) Currently, `VMContRef` objects in the optimized implementation have two fields of type `Payloads`: - `args`, where the arguments and return values stored by the toplevel function running inside the continuation are stored (used by the array call trampoline) - `tag_return_values`, which is used to store payloads of suspended continuations provided by `resume` or `cont.bind` (thus, their types must correspond to the return type of the tag that we suspended with) This PR renames the second field, in order to prepare for `switch`: In the presence of `switch`, the name `tag_return_values` does not make sense anymore: We will be storing `switch` arguments in that vector as well. I've chosen `values` as the new name, inspired by how the baseline implementation calls its counterpart of that vector. I've also renamed a few helper functions related to payload handling in `optimized.rs`. Mostly to remove the redundant `typed_continuations_` prefixes, but also to reflect better what they do. - `typed_continuations_load_payloads -> vmctx_load_payloads` - `typed_continuations_store_payloads -> vmctx_store_payloads` - `typed_continuations_load_tag_return_values -> vmcontref_load_values` - `typed_continuations_store_resume_args -> vmcontref_store_payloads`
avanhatt
added a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Add spec for `safe_divisor_from_imm64` and verify rule. Updates bytecodealliance#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is only useful for debugging the installer itself, which our users really shouldn't need to do.