cranelift-module: Add support for passing a StackMapSink when defining functions#2739
Merged
pchickey merged 1 commit intobytecodealliance:mainfrom Mar 19, 2021
Merged
Conversation
Contributor
Author
|
It looks like these test failures are unrelated to the change |
pchickey
approved these changes
Mar 18, 2021
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Looks good. That CI failure has been happening elsewhere as well, I'll see what we can do to resolve it...
Member
|
It looks like the CI failure happened on the merge commit of #2723 yesterday (though the CI on the PR itself was green) -- possibly related? cc @bnjbvr / @alexcrichton |
Member
|
There's a bit more discussion about CI on #2736 (comment), I haven't had a chance to dig in yet myself |
github-actions
bot
added
cranelift
…g functions Fixes bytecodealliance#2738 This follows the convention set by the existing method of passing a TrapSink by adding another argument for a StackMapSink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #2738
This follows the convention set by the existing method of passing a
TrapSinkby adding another argument for aStackMapSink.