Rename release bundle for mac to replace 'apple' with 'macos'#281
Merged
tschneidereit merged 1 commit intobytecodealliance:masterfrom Aug 16, 2019
Merged
Conversation
|
I would expect the OS to be Darwin on iOS and other Apple operating systems as well, so maybe the condition needs to be updated to match? |
Member
Author
|
This will currently not do the right thing on any other Darwin OSs but macOS. That doesn't seem too bad, given that nobody could ship anything based on Wasmtime for those OSs anyway, because they forbid JITting. I agree that we should fix it, but that's unrelated to this patch, so I'll land this for now. |
avanhatt
added a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appleis really not a useful name here, when the release really is for macOS :)