Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cranelift/wasm/src/environ/spec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,13 @@ pub trait ModuleEnvironment<'data>: TargetEnvironment {
elements: Box<[FuncIndex]>,
) -> WasmResult<()>;

/// Indicates that a declarative element segment was seen in the wasm
/// module.
fn declare_elements(&mut self, elements: Box<[FuncIndex]>) -> WasmResult<()> {
drop(elements);
Ok(())
}

/// Provides the number of passive data segments up front.
///
/// By default this does nothing, but implementations may use this to
Expand Down
2 changes: 1 addition & 1 deletion cranelift/wasm/src/sections_translator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ pub fn parse_element_section<'data>(
environ.declare_passive_element(index, segments)?;
}
ElementKind::Declared => {
// Nothing to do here.
environ.declare_elements(segments)?;
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions crates/environ/src/module_environ.rs
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,13 @@ impl<'data> cranelift_wasm::ModuleEnvironment<'data> for ModuleEnvironment<'data
Ok(())
}

fn declare_elements(&mut self, segments: Box<[FuncIndex]>) -> WasmResult<()> {
for element in segments.iter() {
self.flag_func_possibly_exported(*element);
}
Ok(())
}

fn reserve_function_bodies(&mut self, _count: u32, offset: u64) {
self.result.debuginfo.wasm_file.code_section_offset = offset;
}
Expand Down
27 changes: 27 additions & 0 deletions tests/all/func.rs
Original file line number Diff line number Diff line change
Expand Up @@ -774,3 +774,30 @@ fn wrap_multiple_results() -> anyhow::Result<()> {
f64 "f64" F64 f64::from_bits(a),
}
}

#[test]
fn trampoline_for_declared_elem() -> anyhow::Result<()> {
let engine = Engine::default();

let module = Module::new(
&engine,
r#"
(module
(elem declare func $f)
(func $f)
(func (export "g") (result funcref)
(ref.func $f)
)
)
"#,
)?;

let store = Store::new(&engine);
let instance = Instance::new(&store, &module, &[])?;

let g = instance.get_typed_func::<(), Option<Func>>("g")?;

let func = g.call(())?;
func.unwrap().call(&[])?;
Ok(())
}