Enable more tests on AArch64#2994
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jun 21, 2021
Merged
Conversation
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
19e218b to
7c197fa
Compare
Contributor
Author
|
Well, on the plus side all AArch64 tests pass (including the new additions), but now there is a macOS failure, even though my patch is not supposed to change anything for that platform (since it is not AArch64-based in CI). @alexcrichton Any suggestions? |
Member
|
Oh that's ok, that's a known flaky test failure |
Member
|
(cc @pchickey on the flaky test failure) Details |
Contributor
Author
OK, I started another run - hopefully it will pass this time. |
uweigand
reviewed
Jun 18, 2021
7c197fa to
d0e31ce
Compare
Member
|
This looks good to me now, as far as s390x is concerned. Thanks! |
alexcrichton
approved these changes
Jun 21, 2021
Copyright (c) 2021, Arm Limited.
d0e31ce to
5f482e2
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are partially in support of #2960. With them the tests run on AArch64 should be the same as those executing on x86-64, except for a couple that are specific to the latter platform, 3 that fail under QEMU, and some CLIF tests missing the
target aarch64directive.