Move all trampoline compilation to wasmtime-cranelift#3176
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Aug 12, 2021
Merged
Move all trampoline compilation to wasmtime-cranelift#3176alexcrichton merged 2 commits intobytecodealliance:mainfrom
wasmtime-cranelift#3176alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:wasm", "lightbeam", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit moves compilation of all the trampolines used in wasmtime behind the `Compiler` trait object to live in `wasmtime-cranelift`. The long-term goal of this is to enable depending on cranelift *only* from the `wasmtime-cranelift` crate, so by moving these dependencies we should make that a little more flexible.
alexcrichton
force-pushed
the
less-cranelift
branch
from
b1d1db0 to
69cc81b
Compare
pchickey
approved these changes
Aug 12, 2021
Contributor
|
Fat finger, I clicked approve in the wrong tab - real review pending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves compilation of all the trampolines used in wasmtime
behind the
Compilertrait object to live inwasmtime-cranelift. Thelong-term goal of this is to enable depending on cranelift only from
the
wasmtime-craneliftcrate, so by moving these dependencies weshould make that a little more flexible.