Migrate clz, ctz, popcnt, bitrev, is_null, is_invalid on x64 to ISLE.#3848
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Feb 28, 2022
Merged
Migrate clz, ctz, popcnt, bitrev, is_null, is_invalid on x64 to ISLE.#3848fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
cfallin
force-pushed
the
isle-bitops
branch
2 times, most recently
from
9a08a95 to
e226cd2
Compare
cfallin
changed the title
github-actions
bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
changed the title
abrown
approved these changes
Feb 25, 2022
Member
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
I think this looks good to me with some questions below.
Member
|
One more thought: it might be worthwhile to check that all of the instructions ported here are covered by runtests. |
Member
Author
|
Updated, thanks!
Yep, I've verified that all of the bitops here are exercised by runtests; they actually caught a few bugs during porting. |
Member
Author
|
@abrown you probably want to take another look at the changes related to |
fitzgen
reviewed
Feb 25, 2022
This was referenced Feb 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way this introduces a few new utility bits to the ISLE bindings, e.g. some constructors to do integer arithmetic on constants (I'm surprised we got this far without it!). The bit-twiddling algorithms are, at least to my eye, a bit more legible in this form, but I'm happy to add more comments here if desired since we're making a pass over everything anyway.
Also updated a few stray places I had missed earlier where we can use implicit conversions (the
def_instremovals).