fix(wasi): enable all WasiFiles to be pollable#3913
Merged
pchickey merged 1 commit intobytecodealliance:mainfrom Mar 10, 2022
Merged
fix(wasi): enable all WasiFiles to be pollable#3913pchickey merged 1 commit intobytecodealliance:mainfrom
WasiFiles to be pollable#3913pchickey merged 1 commit intobytecodealliance:mainfrom
Conversation
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
npmccallum
force-pushed
the
wasi
branch
3 times, most recently
from
f65858b to
3de52f1
Compare
Currently, the use of the downcast method means that you have to use one of the hard-coded types. But Enarx needs to define its own `WasiFile` implementations. This works fine, except the resulting files cannot be used in poll because they aren't part of the hard-coded list. Replace this with an accessor method for the pollable type in `WasiFile`. Because we provide a default implementation of the method and manually implement it on all the hard-coded types, this is backwards compatible. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
pchickey
approved these changes
Mar 10, 2022
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Great refactor, I cannot recall why this was written in such a backwards way but I assume that some prior refactor made this possible
npmccallum
added a commit
to npmccallum/wasmtime
that referenced
this pull request
Mar 10, 2022
Currently, the use of the downcast method means that you have to use one of the hard-coded types. But Enarx needs to define its own `WasiFile` implementations. This works fine, except the resulting files cannot be used in poll because they aren't part of the hard-coded list. Replace this with an accessor method for the pollable type in `WasiFile`. Because we provide a default implementation of the method and manually implement it on all the hard-coded types, this is backwards compatible. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the use of the downcast method means that you have to use one
of the hard-coded types. But Enarx needs to define its own
WasiFileimplementations. This works fine, except the resulting files cannot be
used in poll because they aren't part of the hard-coded list.
Replace this with an accessor method for the pollable type in
WasiFile. Because we provide a default implementation of the methodand manually implement it on all the hard-coded types, this is backwards
compatible.
Signed-off-by: Nathaniel McCallum nathaniel@profian.com