Add ISA flag detection for s390x#4101
Conversation
crates/wasmtime/src/engine.rs
Outdated
| _ => None, | ||
| } | ||
| } | ||
| #[cfg(all(target_arch = "s390x", not(target_os = "linux")))] |
There was a problem hiding this comment.
Instead of a maze of #[cfg] statements here, while you're at it could this be updated to use cfg_if!?
Either that or say above let mut enabled = None or something like that. Basically I don't think it's worth it to have lots of negated cfg's to handle this variable.
There was a problem hiding this comment.
I think I tried the let mut enabled = None approach, which caused the compiler to complain about a value that was written, but not read, hence the current approach.
There was a problem hiding this comment.
With a compiler warning I think it's fine to have a local #[allow] for something like this, that's easier to maintain than a complicated #[cfg] clause
There was a problem hiding this comment.
OK, updated patch along those lines.
Adds support for s390x to check_compatible_with_isa_flag, which fixes running the test suite on z15 and later.
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
3 participants
Adds support for s390x to check_compatible_with_isa_flag,
which fixes running the test suite on z15 and later.