Skip to content

Update wasm-tools crates#4246

Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton:update-wasm-tools
Jun 9, 2022
Merged

Update wasm-tools crates#4246
alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton:update-wasm-tools

Conversation

@alexcrichton
Copy link
Member

This commit updates the wasm-tools family of crates, notably pulling in
the refactorings and updates from bytecodealliance/wasm-tools#621 for
the latest iteration of the component model. This commit additionally
updates all support for the component model for these changes, notably:

  • Many bits and pieces of type information was refactored. Many
    FooTypeIndex namings are now TypeFooIndex. Additionally there is
    now TypeIndex as well as ComponentTypeIndex for the two type index
    spaces in a component.

  • A number of new sections are now processed to handle the core and
    component variants.

  • Internal maps were split such as the funcs map into
    component_funcs and funcs (same for instances).

  • Canonical options are now processed individually instead of one bulk
    into definition.

Overall this was not a major update to the internals of handling the
component model in Wasmtime. Instead this was mostly a surface-level
refactoring to make sure that everything lines up with the new binary
format for components.

  • All text syntax used in tests was updated to the new syntax.

@alexcrichton alexcrichton requested a review from peterhuene June 8, 2022 19:25
@alexcrichton
Copy link
Member Author

Note that this is a draft PR due to the fact that it's adding git dependencies for the version bumps happening in bytecodealliance/wasm-tools#631 which are currently blocked on bytecodealliance/wasm-tools#628

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:wasm fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself labels Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Subscribe to Label Action

cc @fitzgen, @peterhuene

Details This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing
  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just some nits.

@peterhuene
Copy link
Member

Looks like a fuzz target needs to update for the wasm-encoder changes too.

This commit updates the wasm-tools family of crates, notably pulling in
the refactorings and updates from bytecodealliance/wasm-tools#621 for
the latest iteration of the component model. This commit additionally
updates all support for the component model for these changes, notably:

* Many bits and pieces of type information was refactored. Many
  `FooTypeIndex` namings are now `TypeFooIndex`. Additionally there is
  now `TypeIndex` as well as `ComponentTypeIndex` for the two type index
  spaces in a component.

* A number of new sections are now processed to handle the core and
  component variants.

* Internal maps were split such as the `funcs` map into
  `component_funcs` and `funcs` (same for `instances`).

* Canonical options are now processed individually instead of one bulk
  `into` definition.

Overall this was not a major update to the internals of handling the
component model in Wasmtime. Instead this was mostly a surface-level
refactoring to make sure that everything lines up with the new binary
format for components.

* All text syntax used in tests was updated to the new syntax.
@alexcrichton alexcrichton marked this pull request as ready for review June 9, 2022 15:38
@alexcrichton alexcrichton merged commit 7d7ddce into bytecodealliance:main Jun 9, 2022
@alexcrichton alexcrichton deleted the update-wasm-tools branch June 9, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:wasm cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants