s390x: Support preserve_frame_pointers flag#4477
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Jul 21, 2022
Merged
s390x: Support preserve_frame_pointers flag#4477fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
cranelift
fitzgen
approved these changes
Jul 20, 2022
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
LGTM, thanks! Mind adding a filetest that does set preserver_frame_pointers = true similar to how my PR introducing the new flag did for aarch64 and x64?
On s390x, we do not have a frame pointer that can be used to chain stack frames for easy unwinding. Instead, our ABI defines a stack "backchain" mechanism that can be used to the same effect. This PR uses that backchain mechanism to implement the new preserve_frame_pointers flags introduced here: bytecodealliance#4469
uweigand
force-pushed
the
s390x-backchain
branch
from
ed5eedb to
c81b1e9
Compare
Member
Author
Oops, I had those, just forgot "git add" :-) |
fitzgen
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On s390x, we do not have a frame pointer that can be used to chain
stack frames for easy unwinding. Instead, our ABI defines a stack
"backchain" mechanism that can be used to the same effect.
This PR uses that backchain mechanism to implement the new
preserve_frame_pointers flags introduced here:
#4469
FYI @fitzgen @cfallin