wasmtime: Add lots of logging for externrefs and table_ops fuzz target#4583
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Aug 2, 2022
Merged
wasmtime: Add lots of logging for externrefs and table_ops fuzz target#4583fitzgen merged 1 commit intobytecodealliance:mainfrom
externrefs and table_ops fuzz target#4583fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
…arget I essentially add these same logs back in every time I'm debugging something related to this fuzz target or `externref`s in general. Probably like 5 times I've added roughly these logs. We should just make them available whenever we need them via `RUST_LOG=wasmtime_runtime=trace`. This also changes a couple `if let`s to `unwrap`s that are now infallible after
alexcrichton
approved these changes
Aug 2, 2022
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "fuzzing", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I essentially add these same logs back in every time I'm debugging something
related to this fuzz target or
externrefs in general. Probably like 5 timesI've added roughly these logs. We should just make them available whenever we
need them via
RUST_LOG=wasmtime_runtime=trace.This also changes a couple
if lets tounwraps that are now infallible after #4431.